[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/context
From:       Nikolaj Hald Nielsen <nhnfreespirit () gmail ! com>
Date:       2009-07-19 11:19:12
Message-ID: 9d527020907190419y6e93232cu35e4940250909b79 () mail ! gmail ! com
[Download RAW message or body]

>
> We should keep the 1.4 logic which was simple, easy to implement,
> logical and predictable:
>
> if has cached lyrics and not force reload - show them;
> else - fetch, store in cache, show them;
>

That sounds perfectly reasonable!

I did not play around with this stuff in 1.4 so I did not know the original
logic behind it, but this is certainly not how the 2.x version was
originally written :-) It should be fairly simple to retool it to work this
way though, especially since my 2 fixes were basically steps along that path
already.

- Nikolaj

[Attachment #3 (text/html)]

<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px \
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div \
class="im"> </div>We should keep the 1.4 logic which was simple, easy to \
implement,<br> logical and predictable:<br>
<br>
if has cached lyrics and not force reload - show them;<br>
else - fetch, store in cache, show them;<br>
</blockquote></div><br>That sounds perfectly reasonable!<br><br>I did not play around \
with this stuff in 1.4 so I did not know the original logic behind it, but this is \
certainly not how the 2.x version was originally written :-) It should be fairly \
simple to retool it to work this way though, especially since my 2 fixes were \
basically steps along that path already.<br>  <br>- Nikolaj<br>



[prev in list] [next in list] [prev in thread] [next in thread]