[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/context
From:       Orville Bennett <illogical1 () gmail ! com>
Date:       2009-07-18 14:39:49
Message-ID: 4A61DEB5.4020705 () gmail ! com
[Download RAW message or body]

Nikolaj Hald Nielsen wrote:
> SVN commit 998707 by nhnielsen:
> 
> If we have cached lyrics, show these if lyrics download job returns an error. This \
>                 also allows lyrics to be shown when offline!
> BUG: 197589
> 
> M  +27 -0     LyricsManager.cpp
> 
> 
> --- trunk/extragear/multimedia/amarok/src/context/LyricsManager.cpp #998706:998707
> @@ -209,6 +209,33 @@
> void
> LyricsManager::lyricsError( const QString&error )
> {
> +
> +    //if we have cached lyris there is absolutely no point in not showing these..
> +    Meta::TrackPtr currentTrack = The::engineController()->currentTrack();
> +    if( !currentTrack->cachedLyrics().isEmpty() )
> +    {
> +        debug()<<  "showing cached lyrics!";
> +        //TODO: add some sort of feedback that we could not fetch new ones
> +        //so we are showing a cached result
Unnecessary. It should just work and the details of how it's working 
aren't necessary, or useful.


[prev in list] [next in list] [prev in thread] [next in thread]