[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/multimedia/amarok/src
From:       Nikolaj Hald Nielsen <nhnFreespirit () gmail ! com>
Date:       2009-07-18 12:14:18
Message-ID: 1247919258.591653.31051.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 998725 by nhnielsen:

Fix escaped space "%20" being shown at the end of each filter value in the LibriVox \
                service
BUG: 190704



 M  +1 -1      scripts/librivox_service/main.js  
 M  +1 -0      services/scriptable/ScriptableServiceQueryMaker.cpp  


--- trunk/extragear/multimedia/amarok/src/scripts/librivox_service/main.js \
#998724:998725 @@ -226,7 +226,7 @@
 
     if ( filter != "" )
     {
-        name = filter.replace( "%20", " " );
+        name = filter.replace( /%20/g, " " );
     }
     else
     {
--- trunk/extragear/multimedia/amarok/src/services/scriptable/ScriptableServiceQueryMaker.cpp \
#998724:998725 @@ -447,6 +447,7 @@
 
     if ( value == Meta::valTitle )
     {
+        //I am sure there is a really good reason to add this space, as nothing \
works if it is removed, but WHY?!?  d->filter += filter + ' ';
         d->filter = d->filter.replace( ' ', "%20" );
     }


[prev in list] [next in list] [prev in thread] [next in thread]