[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps/konsole/src
From:       Pino Toscano <pino () kde ! org>
Date:       2009-07-13 21:31:44
Message-ID: 200907132331.51976.pino () kde ! org
[Download RAW message or body]


Hi,

> What's the purpose of this?  Does it not compile on your system?

Yes, with stricter compile flags (like -pedantic) it did not compile.
This was due to the "bool readProcInfo(int pid)", implemented only on 
Q_OS_MAC, leaving an empty implementation elsewhere and thus breaking because 
of a non-void function returning void. Yes, the easy solution would have been 
making it return false if !Q_OS_MAC, but given that the class is used only 
there, then it makes sense (at least IMHO) to just compile it only on that OS.

-- 
Pino Toscano

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]