[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/libs/webkitkde
From:       Laurent Montel <montel () kde ! org>
Date:       2009-07-09 11:43:55
Message-ID: 1247139835.589968.6197.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 993719 by mlaurent:

const'ify


 M  +2 -2      kdewebkit/settings/webkitsettings.cpp  
 M  +2 -1      part/webkitpart.cpp  
 M  +3 -2      part/webview.cpp  


--- trunk/playground/libs/webkitkde/kdewebkit/settings/webkitsettings.cpp \
#993718:993719 @@ -776,7 +776,7 @@
     // ### refactor somewhat
     if (url.length()>2 && url[0]=='/' && url[url.length()-1] == '/')
     {
-        QString inside = url.mid(1, url.length()-2);
+        const QString inside = url.mid(1, url.length()-2);
         rx.setPattern(inside);
     }
     else
@@ -788,7 +788,7 @@
     if (rx.isValid())
     {
         int last=config.readEntry("Count", 0);
-        QString key = "Filter-" + QString::number(last);
+        const QString key = "Filter-" + QString::number(last);
         config.writeEntry(key, url);
         config.writeEntry("Count",last+1);
         config.sync();
--- trunk/playground/libs/webkitkde/part/webkitpart.cpp #993718:993719
@@ -384,7 +384,8 @@
 {
     QList<KUrl> urls;
     urls.append(part->view()->contextMenuResult().imageUrl());
-    for (int i = 0; i != urls.count(); i++) {
+    const int nbUrls = urls.count();
+    for (int i = 0; i != nbUrls; i++) {
         QString file = KFileDialog::getSaveFileName(KUrl(), QString(), \
part->widget());  KIO::NetAccess::file_copy(urls.at(i), file, part->widget());
     }
--- trunk/playground/libs/webkitkde/part/webview.cpp #993718:993719
@@ -254,7 +254,7 @@
 
     QString name;
     if (KUriFilter::self()->filterUri(data, list)) {
-        QString iconPath = KStandardDirs::locate("cache", \
KMimeType::favIconForUrl(data.uri()) + ".png"); +        const QString iconPath = \
KStandardDirs::locate("cache", KMimeType::favIconForUrl(data.uri()) + ".png");  if \
(iconPath.isEmpty())  icon = KIcon("edit-find");
         else
@@ -292,7 +292,7 @@
             data.setData(searchProviderPrefix + "some keyword");
 
             if (KUriFilter::self()->filterUri(data, list)) {
-                QString iconPath = KStandardDirs::locate("cache", \
KMimeType::favIconForUrl(data.uri()) + ".png"); +                const QString \
iconPath = KStandardDirs::locate("cache", KMimeType::favIconForUrl(data.uri()) + \
".png");  if (iconPath.isEmpty())
                     icon = KIcon("edit-find");
                 else
@@ -339,3 +339,4 @@
 
     emit d->part->browserExtension()->openUrlRequest(d->selectedTextAsOneLine(), \
KParts::OpenUrlArguments(), browserArgs);  }
+


[prev in list] [next in list] [prev in thread] [next in thread]