[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevplatform/plugins
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2009-06-06 23:39:56
Message-ID: 20090606233956.GB29917 () neo ! apaku ! dnsalias ! org
[Download RAW message or body]

On 06.06.09 21:05:34, Andreas Hartmetz wrote:
> SVN commit 978363 by ahartmetz:
> 
> link with gold
> 
>  M  +6 -4      git/tests/CMakeLists.txt  
>  M  +2 -0      mercurial/tests/CMakeLists.txt  
>  M  +1 -1      snippet/CMakeLists.txt  
> 
> 
> --- trunk/KDE/kdevplatform/plugins/git/tests/CMakeLists.txt #978362:978363
> @@ -20,13 +20,15 @@
>      set( EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR} )
>  	set(gitInitTest_SRCS initTest.cpp ../gitplugin.cpp)
>      kde4_add_unit_test(kdevgit-test ${gitInitTest_SRCS})
> -	target_link_libraries(kdevgit-test
> -		${QT_QTTEST_LIBRARY}
> -		${KDE4_KDECORE_LIBS}
> +    target_link_libraries(kdevgit-test
> +        ${QT_QTTEST_LIBRARY}
> +        ${KDE4_KDECORE_LIBS}
> +        kdevplatformshell
> +        kdevplatforminterfaces
>          kdevplatformutil
>          kdevplatformvcs
>          kdevplatformtestshell

This shouldn't be needed kdevplatformtestshell sets kdevplatformshell as
link-interface library, which means the linker is supposed to automatically
link the library in. This suggests that either your linker is broken, or
CMake needs special support for the gold linker. Please revert this and the
similar commit you've done to kdevelop (the same applies to the other 2
files this commit changes).

Andreas

-- 
You will forget that you ever knew me.
[prev in list] [next in list] [prev in thread] [next in thread]