[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/collection/sqlcollection
From:       Gary Steinert <gary.steinert.ml () googlemail ! com>
Date:       2009-06-04 0:27:45
Message-ID: 200906040127.46546.gary.steinert () gmail ! com
[Download RAW message or body]

On Wednesday 03 June 2009 15:06:24 Seb Ruiz wrote:
> 2009/6/4 Jeff Mitchell <mitchell@kde.org>:
> > SVN commit 977118 by mitchell:
> >
> > Remove duplicated code, and a couple other 
changes:
> > 1) Add "f." as an acceptible "featuring" substitute 
(like "feat.")
> > 2) Change detection code to have spaces around " 
featuring ", " feat. "
> > and " f. ".  Reasoning: This is normal behavior, and 
also removes the
> > slight possibility of false positives in the abbreviated 
cases.
>
> This is a regression. Many of my tracks are tagged 
Artist (feat.
> someone) - with no spaces.

I think the spaces around "featuring" should be retained, 
at least for the "f." option. Im sure there are many bands 
with names comprising initials (AFI for one, which I have 
seen tagged many times as a.f.i) in these cases, a false 
positive would be generated. I can't off the top of my 
head think of any situations  where a false negative 
would be returned if ( " f." || "(f." ) were used.

I realise that doesn't read too well, but the thoughts in 
my head very rarely translate to words veery well =P a 
14 hour shift at work doesn't help matters either =P

Gary Steinert
[prev in list] [next in list] [prev in thread] [next in thread]