[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-promo
Subject:    [kde-promo] KDE/kdelibs/kio/kio
From:       Michael Pyne <mpyne () purinchu ! net>
Date:       2009-05-29 14:15:40
Message-ID: 1243606540.578785.2323.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 974506 by mpyne:

Instead of simply not showing custom icons for untrusted executable .desktop files, show the
custom icon with a warning symbol overlaid on top of it.

This might be a good idea to cover if we're doing a KDE 4.3 Visual Guide as well, since I
expect that people with lots of custom icons on their desktop may be wondering what's going
on at first.

CCMAIL:fredrik@kde.org
CCMAIL:kde-promo@kde.org


 M  +11 -3     kfileitem.cpp  


--- trunk/KDE/kdelibs/kio/kio/kfileitem.cpp #974505:974506
@@ -761,9 +761,6 @@
                 }
             }
         }
-    } else if ( group.hasKey( "Exec" ) && !KDesktopFile::isAuthorizedDesktopFile( path ) ) {
-        // Disable custom icons for untrusted executables
-        return QString("application-x-desktop");
     }
     return icon;
 }
@@ -813,6 +810,17 @@
         names.append("object-locked");
     }
 
+    if ( isDesktopFile() ) {
+        KDesktopFile cfg( localPath() );
+        const KConfigGroup group = cfg.desktopGroup();
+
+        // Add a warning emblem if this is an executable desktop file
+        // which is untrusted.
+        if ( group.hasKey( "Exec" ) && !KDesktopFile::isAuthorizedDesktopFile( localPath() ) ) {
+            names.append( "emblem-important" );
+        }
+    }
+
     if ( isHidden() ) {
         names.append("hidden");
     }
 
_______________________________________________
This message is from the kde-promo mailing list.

Visit https://mail.kde.org/mailman/listinfo/kde-promo to unsubscribe, set digest on or temporarily stop your subscription.

[prev in list] [next in list] [prev in thread] [next in thread]