[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/libkdepim
From:       Thomas McGuire <mcguire () kde ! org>
Date:       2009-05-31 21:23:31
Message-ID: 200905312323.36877.mcguire () kde ! org
[Download RAW message or body]


Hi,

On Sunday 31 May 2009 15:44:25 Olivier Trichet wrote:
> Hello Thomas,
>
> Le mercredi 13 mai 2009 14:22:42 Thomas McGuire, vous avez écrit :
> > SVN commit 967413 by tmcguire:
> >
> > - Don't restore the lastSectionStrechted property, that produces bogus
> > resize events.
> > - Don't bogusly set the size of the columns to 10, I see no
> > sense in this.
> >
> > Olivier, please review and make sure it still works with KNode.
> >
> >
> >  M  +0 -3      treewidget.cpp
> >
> >
> > --- trunk/KDE/kdepim/libkdepim/treewidget.cpp #967412:967413
> > @@ -109,7 +109,6 @@
> >
> >    bool sectionsWereClickable = header()->isClickable();
> >    bool sectionsWereMovable = header()->isMovable();
> > -  bool lastSectionWasStretched = header()->stretchLastSection();
> >    bool sortIndicatorWasShown = header()->isSortIndicatorShown();
> >    Qt::Alignment originalDefaultAlignment = header()->defaultAlignment();
> >    //int defaultSectionSize = header()->defaultSectionSize();
> > @@ -138,7 +137,6 @@
> >    for ( int i = 0 ; i < cc ; i++ )
> >    {
> >       savedSizes[ i ] = header()->sectionSize( i );
> > -     header()->resizeSection( i , 10 );
>
> This line is still needed, otherwise the width of the last column is not
> restored correctly (see the comment section above in the code)
>
> Will it break something in KMail if I revert this change ?

Seems nothing will break, so please revert the last line. I just though the 
line was nonsense and would trigger a spurious resize, but seems that this is 
still needed.

Regards,
Thomas

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]