[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: playground/pim/krss
From:       Dmitry Ivanov <vonami () gmail ! com>
Date:       2009-05-27 12:52:37
Message-ID: 6df8d8b90905270552g2bc9ab6byd23c752ce7d54e3f () mail ! gmail ! com
[Download RAW message or body]

On 5/26/09, Frank Osterfeld <frank@kdab.com> wrote:
>> SVN commit 972610 by divanov:
>>
>> Reintroduce item monitoring, fine-grained this time since
>> it affects performance a lot
>
>> -        explicit ItemListing( const QList<Item>& item, QObject* parent=0
>> ); +        explicit ItemListing( const QList<Item>& items, const
>> Akonadi::ItemFetchScope& fetchScope, +
>>[...]
>> -        void connectToFeed( const Feed* );
>> +        void connectToFeed( const boost::shared_ptr<const Feed>& feed );
>> +        void setFetchScope( const Akonadi::ItemFetchScope& fetchScope );
>> +        Akonadi::ItemFetchScope& fetchScope();
>
> Should that really be a reference? It looks like one can change the fetch
> scope behind the back of the ItemListing? Probably there should be a setter
> instead.

Actually, those two methods were committed my mistake. I think there
is no point in
changing the fetch scope during the lifetime of an ItemListing (the
fetch scope is set
in the ctor).

Dmitry
[prev in list] [next in list] [prev in thread] [next in thread]