From kde-commits  Tue May 26 06:41:55 2009
From: Frank Osterfeld <frank () kdab ! com>
Date: Tue, 26 May 2009 06:41:55 +0000
To: kde-commits
Subject: Re: playground/pim/krss
Message-Id: <200905260841.56200.frank () kdab ! com>
X-MARC-Message: https://marc.info/?l=kde-commits&m=124332016526617

> SVN commit 972610 by divanov:
>
> Reintroduce item monitoring, fine-grained this time since
> it affects performance a lot

> -        explicit ItemListing( const QList<Item>& item, QObject* parent=0
> ); +        explicit ItemListing( const QList<Item>& items, const
> Akonadi::ItemFetchScope& fetchScope, +                             
>[...]
> -        void connectToFeed( const Feed* );
> +        void connectToFeed( const boost::shared_ptr<const Feed>& feed );
> +        void setFetchScope( const Akonadi::ItemFetchScope& fetchScope );
> +        Akonadi::ItemFetchScope& fetchScope();

Should that really be a reference? It looks like one can change the fetch 
scope behind the back of the ItemListing? Probably there should be a setter 
instead.

-- 
Frank Osterfeld | frank@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel. Germany +49-30-521325470, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions