[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.2/kdemultimedia/dragonplayer/src/app
From:       Raphael Kubo da Costa <kubito () gmail ! com>
Date:       2009-05-22 4:35:58
Message-ID: 1242966958.393963.28634.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 971233 by rkcosta:

Backport commit 971230.

Remove hack that immediately displayed the toolbar when
the mouse was moved over its position if it was at the top,
even when it was on the left, right or at the bottom.

CCBUG: 170071
CCMAIL: imonroe@kde.org


 M  +2 -8      fullScreenToolBarHandler.cpp  


--- branches/KDE/4.2/kdemultimedia/dragonplayer/src/app/fullScreenToolBarHandler.cpp #971232:971233
@@ -55,20 +55,14 @@
 
         QMouseEvent const * const me = (QMouseEvent*)e;
         if (m_stay_hidden_for_a_bit) {
-            debug() << "1 staying hidden for a big";
+            debug() << "staying hidden for a bit";
             // wait for a small pause before showing the toolbar again
             // usage = user removes mouse from toolbar after using it
             // toolbar disappears (usage is over) but usually we show
             // toolbar immediately when mouse is moved.. so we need this hack
 
-            // HACK if user thrusts mouse to top, we assume they really want the toolbar
-            // back. Is hack as 80% of users have at top, but 20% at bottom, we don't cater
-            // for the 20% as lots more code, for now.
-            if (me->pos().y() < m_toolbar->height())
-            {
-                debug() << "goto show_toolbar";
+            if (m_toolbar->geometry().contains(me->pos()))
                 goto show_toolbar;
-            }
 
             m_timer_id = startTimer( 100 );
         }
[prev in list] [next in list] [prev in thread] [next in thread]