[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: KDE/kdeplasma-addons (silent)
From: Andrew Stromme <astromme () chatonka ! com>
Date: 2009-05-20 23:42:53
Message-ID: 1242862973.167344.4084.nullmailer () svn ! kde ! org
[Download RAW message or body]
SVN commit 970846 by astromme:
SVN_SILENT Krazy (ebn) fixes
M +1 -1 applets/rememberthemilk/general.ui
M +1 -1 applets/rememberthemilk/rememberthemilk-plasmoid.cpp
M +1 -1 applets/rememberthemilk/taskeditor.cpp
M +1 -1 applets/rememberthemilk/taskeditor.h
M +4 -4 applets/rememberthemilk/taskmodel.cpp
M +1 -1 applets/rememberthemilk/taskmodel.h
M +2 -2 applets/rememberthemilk/tasksortfilter.cpp
M +1 -1 applets/rememberthemilk/tasksortfilter.h
M +1 -1 dataengines/rememberthemilk/listssource.h
M +1 -1 dataengines/rememberthemilk/taskservice.cpp
M +1 -1 dataengines/rememberthemilk/taskservice.h
M +1 -1 dataengines/rememberthemilk/tasksource.cpp
M +1 -1 libs/rtm/auth.cpp
M +1 -1 libs/rtm/request.cpp
M +2 -2 libs/rtm/rtm.h
M +0 -2 libs/rtm/session.cpp
M +0 -1 libs/rtm/session_p.h
M +1 -1 libs/rtm/task.cpp
M +5 -0 libs/rtm/task_p.h
M +1 -1 libs/rtm/xmlreaders.cpp
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/general.ui #970845:970846
@@ -28,7 +28,7 @@
</widget>
</item>
<item row="0" column="1">
- <widget class="QComboBox" name="sortType">
+ <widget class="KComboBox" name="sortType">
<property name="whatsThis">
<string>Change the current sorting method.
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/rememberthemilk-plasmoid.cpp #970845:970846
@@ -217,7 +217,7 @@
//while (m_categoriesBar->count())
// m_categoriesBar->removeTab(0);
//m_lists.clear(); //FIXME: What happens when a list is deleted?
- foreach(QString key, data.keys()) {
+ foreach(const QString &key, data.keys()) {
if (!m_lists.contains(key.toULongLong())) {
m_categoriesBar->addTab(data.value(key).toString());
m_lists.append(key.toULongLong());
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/taskeditor.cpp #970845:970846
@@ -162,7 +162,7 @@
}
if (!tagsEdit->text().isEmpty()) {
- QStringList tags = tagsEdit->text().split(",");
+ QStringList tags = tagsEdit->text().split(',');
KConfigGroup cg = m_service->operationDescription("setTags");
cg.writeEntry("tags", tags);
emit jobStarted(m_service->startOperationCall(cg));
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/taskeditor.h #970845:970846
@@ -40,7 +40,7 @@
{
Q_OBJECT
public:
- TaskEditor(Plasma::DataEngine *engine, QGraphicsWidget *parent = 0);
+ explicit TaskEditor(Plasma::DataEngine *engine, QGraphicsWidget *parent = 0);
~TaskEditor();
void paint(QPainter* painter, const QStyleOptionGraphicsItem* option, QWidget* widget);
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/taskmodel.cpp #970845:970846
@@ -134,7 +134,7 @@
QDataStream stream(&encodedData, QIODevice::WriteOnly);
- foreach (QModelIndex index, indexes)
+ foreach(const QModelIndex &index, indexes)
if (index.isValid())
stream << index.data(Qt::RTMTaskIdRole).toString();
@@ -182,7 +182,7 @@
}
//int beginRow = rowCount(priorityParent);
- foreach(QString id, newItems) {
+ foreach(const QString &id, newItems) {
if (m_taskItems.contains(id.toULongLong())) {
TaskItem *item = taskFromId(id.toULongLong());
if (item) {
@@ -236,7 +236,7 @@
void TaskModel::listUpdate(qulonglong listId)
{
if (m_listItems.contains(listId)) {
- foreach(qulonglong taskid, m_listItems.value(listId)->tasks) {
+ foreach(const qulonglong &taskid, m_listItems.value(listId)->tasks) {
engine->connectSource("Task:" + QString::number(taskid), this);
}
}
@@ -269,7 +269,7 @@
item->tasks.clear();
- foreach(QString key, data.keys()) {
+ foreach(const QString &key, data.keys()) {
if (key != "id" && key != "name" && key != "smart")
item->tasks.append(key.toULongLong());
}
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/taskmodel.h #970845:970846
@@ -45,7 +45,7 @@
{
Q_OBJECT
public:
- TaskModel(Plasma::DataEngine *engine, QObject *parent=0);
+ explicit TaskModel(Plasma::DataEngine *engine, QObject *parent=0);
QFlags< Qt::DropAction > supportedDropActions() const;
QFlags< Qt::ItemFlag > flags(const QModelIndex& index) const;
QStringList mimeTypes() const;
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/tasksortfilter.cpp #970845:970846
@@ -109,7 +109,7 @@
if (item.isValid()) {
switch (filterOn) {
case Tags:
- foreach(QString tag, item.data(Qt::RTMTagsRole).toStringList()) {
+ foreach(const QString &tag, item.data(Qt::RTMTagsRole).toStringList()) {
if (tag.contains(filterRegExp()))
return true;
}
@@ -130,7 +130,7 @@
(item.data(Qt::RTMDueRole).toDateTime().toString(Qt::LocalDate).contains(filterRegExp()))
)
return true;
- foreach(QString tag, item.data(Qt::RTMTagsRole).toStringList()) {
+ foreach(const QString &tag, item.data(Qt::RTMTagsRole).toStringList()) {
if (tag.contains(filterRegExp()))
return true;
}
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/tasksortfilter.h #970845:970846
@@ -31,7 +31,7 @@
{
Q_OBJECT
public:
- TaskSortFilter(TaskModel* model, QObject* parent = 0);
+ explicit TaskSortFilter(TaskModel* model, QObject* parent = 0);
bool filterAcceptsRow(int source_row, const QModelIndex& source_parent) const;
bool filterAcceptsColumn(int source_column, const QModelIndex& source_parent) const;
bool lessThan(const QModelIndex& left, const QModelIndex& right) const;
--- trunk/KDE/kdeplasma-addons/dataengines/rememberthemilk/listssource.h #970845:970846
@@ -57,4 +57,4 @@
QTimer timer;
};
-#endif
\ No newline at end of file
+#endif
--- trunk/KDE/kdeplasma-addons/dataengines/rememberthemilk/taskservice.cpp #970845:970846
@@ -97,4 +97,4 @@
setError(false);
setResult(true);
this->deleteLater();
-}
\ No newline at end of file
+}
--- trunk/KDE/kdeplasma-addons/dataengines/rememberthemilk/taskservice.h #970845:970846
@@ -58,4 +58,4 @@
void result(RTM::Task *task);
};
-#endif // TASKSERVICE_H
\ No newline at end of file
+#endif // TASKSERVICE_H
--- trunk/KDE/kdeplasma-addons/dataengines/rememberthemilk/tasksource.cpp #970845:970846
@@ -65,4 +65,4 @@
}
checkForUpdate();
-}
\ No newline at end of file
+}
--- trunk/KDE/kdeplasma-addons/libs/rtm/auth.cpp #970845:970846
@@ -169,7 +169,7 @@
break;
}
QString url = RTM::baseAuthUrl;
- foreach(QString key, arguments.keys())
+ foreach(const QString &key, arguments.keys())
url.append('&' + key + '=' + arguments.value(key));
return url;
}
--- trunk/KDE/kdeplasma-addons/libs/rtm/request.cpp #970845:970846
@@ -133,7 +133,7 @@
}
//kDebug() << "Creating url";
QString url = RTM::baseMethodUrl;
- foreach(QString key, arguments.keys())
+ foreach(const QString &key, arguments.keys())
url.append('&' + key + '=' + arguments.value(key));
return url;
}
--- trunk/KDE/kdeplasma-addons/libs/rtm/rtm.h #970845:970846
@@ -17,8 +17,8 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
-#ifndef DEFINES_H
-#define DEFINES_H
+#ifndef RTM_H
+#define RTM_H
#include "rtm_export.h"
--- trunk/KDE/kdeplasma-addons/libs/rtm/session.cpp #970845:970846
@@ -27,7 +27,6 @@
#include <QUrl>
#include <QStringList>
-#include <QString>
#include <QByteArray>
#include <QCryptographicHash>
#include <QHttp>
@@ -35,7 +34,6 @@
#include <QCoreApplication>
#include <QDomDocument>
-#include <QString>
#include <QDomNode>
#include <QDomElement>
#include <QDomNodeList>
--- trunk/KDE/kdeplasma-addons/libs/rtm/session_p.h #970845:970846
@@ -36,7 +36,6 @@
#include <QBuffer>
#include <QCoreApplication>
#include <QDomDocument>
-#include <QString>
#include <QDomNode>
#include <QDomElement>
#include <QDomNodeList>
--- trunk/KDE/kdeplasma-addons/libs/rtm/task.cpp #970845:970846
@@ -204,7 +204,7 @@
return true;
}
void RTM::Task::removeAllNotes() {
- foreach(RTM::NoteId id, d->notes.keys())
+ foreach(const RTM::NoteId &id, d->notes.keys())
removeNote(id);
}
bool RTM::Task::removeNote(RTM::NoteId noteid) {
--- trunk/KDE/kdeplasma-addons/libs/rtm/task_p.h #970845:970846
@@ -17,6 +17,9 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
+#ifndef RTM_TASK_P_H
+#define RTM_TASK_P_H
+
#include "task.h"
#include "request.h"
@@ -63,3 +66,5 @@
QMap<RTM::NoteId, RTM::Note> notes;
};
+
+#endif // RTM_TASK_P_H
--- trunk/KDE/kdeplasma-addons/libs/rtm/xmlreaders.cpp #970845:970846
@@ -124,7 +124,7 @@
void RTM::TasksReader::readTransaction() {
// If we're not using a getList method we need to jump to the correct spot
- QStringList splitMethod = request->method().split(".");
+ QStringList splitMethod = request->method().split('.');
readNext();
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic