[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/plasma/applets/systemtray/protocols/dbussystemtray
From:       Marco Martin <notmart () gmail ! com>
Date:       2009-05-18 18:55:37
Message-ID: 1242672937.126906.26272.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 969716 by mart:

don't try to connect on an invalid DBus interface, does this fixes bug
193126?

CCBUG: 193126?


 M  +8 -5      dbussystemtraytask.cpp  


--- trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp \
#969715:969716 @@ -112,12 +112,15 @@
     d->notificationItemInterface = new org::kde::NotificationItem(service, \
                "/NotificationItem",
                                                                           \
QDBusConnection::sessionBus(), this);  
-    d->refresh();
+    //TODO: how to behave if its not valid?
+    if (d->notificationItemInterface->isValid()) {
+        d->refresh();
 
-    connect(d->notificationItemInterface, SIGNAL(NewIcon()), this, SLOT(refresh()));
-    connect(d->notificationItemInterface, SIGNAL(NewAttentionIcon()), this, \
                SLOT(refresh()));
-    connect(d->notificationItemInterface, SIGNAL(NewToolTip()), this, \
                SLOT(refresh()));
-    connect(d->notificationItemInterface, SIGNAL(NewStatus(QString)), this, \
SLOT(syncStatus(QString))); +        connect(d->notificationItemInterface, \
SIGNAL(NewIcon()), this, SLOT(refresh())); +        \
connect(d->notificationItemInterface, SIGNAL(NewAttentionIcon()), this, \
SLOT(refresh())); +        connect(d->notificationItemInterface, \
SIGNAL(NewToolTip()), this, SLOT(refresh())); +        \
connect(d->notificationItemInterface, SIGNAL(NewStatus(QString)), this, \
SLOT(syncStatus(QString))); +    }
 }
 
 


[prev in list] [next in list] [prev in thread] [next in thread]