[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kate/undo
From:       Bernhard Beschow <bbeschow () cs ! tu-berlin ! de>
Date:       2009-05-17 12:47:42
Message-ID: 1242564462.098181.25677.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 969067 by beschow:

hide some internals of KateUndoGroup

 M  +11 -17    kateundo.cpp  
 M  +1 -23     kateundo.h  
 M  +1 -8      kateundomanager.cpp  


--- trunk/KDE/kdelibs/kate/undo/kateundo.cpp #969066:969067
@@ -190,6 +190,11 @@
   , m_undoCursor(-1, -1)
   , m_redoCursor(-1, -1)
 {
+  if (document->activeKateView())
+  {
+    m_undoCursor = document->activeKateView()->cursorPosition();
+    m_undoSelection = document->activeKateView()->selectionRange();
+  }
 }
 
 KateUndoGroup::~KateUndoGroup ()
@@ -243,26 +248,15 @@
   document()->editEnd ();
 }
 
-void KateUndoGroup::setUndoSelection(const KTextEditor::Range &selection)
+void KateUndoGroup::editEnd()
 {
-  m_undoSelection = selection;
+  if (document()->activeKateView())
+  {
+    m_redoCursor = document()->activeKateView()->cursorPosition();
+    m_redoSelection = document()->activeKateView()->selectionRange();
+  }
 }
 
-void KateUndoGroup::setRedoSelection(const KTextEditor::Range &selection)
-{
-  m_redoSelection = selection;
-}
-
-void KateUndoGroup::setUndoCursor(const KTextEditor::Cursor &cursor)
-{
-  m_undoCursor = cursor;
-}
-
-void KateUndoGroup::setRedoCursor(const KTextEditor::Cursor &cursor)
-{
-  m_redoCursor = cursor;
-}
-
 void KateUndoGroup::addItem(KateUndo* u)
 {
   if (u->isEmpty())
--- trunk/KDE/kdelibs/kate/undo/kateundo.h #969066:969067
@@ -383,31 +383,9 @@
      */
     KateUndo::UndoType type() const { return KateUndo::editGroup; }
 
-    /**
-     * sets the undo text selection range for the edit group.
-     * @param selection selection to remember
-     */
-    void setUndoSelection (const KTextEditor::Range &selection);
+    void editEnd();
 
     /**
-     * sets the redo text selection range for the edit group.
-     * @param selection selection to remember
-     */
-    void setRedoSelection (const KTextEditor::Range &selection);
-
-    /**
-     * sets the undo cursor position for the edit group.
-     * @param selection selection to remember
-     */
-    void setUndoCursor(const KTextEditor::Cursor &cursor);
-
-    /**
-     * sets the redo cursor position for the edit group.
-     * @param selection selection to remember
-     */
-    void setRedoCursor(const KTextEditor::Cursor &cursor);
-
-    /**
      * merge this group with an other
      * @param newGroup group to merge into this one
      * @param complex set if a complex undo
--- trunk/KDE/kdelibs/kate/undo/kateundomanager.cpp #969066:969067
@@ -60,10 +60,6 @@
 
   // new current undo item
   m_editCurrentUndo = new KateUndoGroup(m_document);
-  if (m_document->activeKateView()) {
-    m_editCurrentUndo->setUndoCursor(m_document->activeKateView()->cursorPosition());
-    m_editCurrentUndo->setUndoSelection(m_document->activeKateView()->selectionRange());
-  }
 
   Q_ASSERT(m_editCurrentUndo != 0); // a new undo group must be created by this method
 }
@@ -75,10 +71,7 @@
 
     bool changedUndo = false;
 
-    if (m_document->activeKateView()) {
-        m_editCurrentUndo->setRedoCursor(m_document->activeKateView()->cursorPosition());
-        m_editCurrentUndo->setRedoSelection(m_document->activeKateView()->selectionRange());
-    }
+    m_editCurrentUndo->editEnd();
 
     if (m_editCurrentUndo->isEmpty()) {
       delete m_editCurrentUndo;
[prev in list] [next in list] [prev in thread] [next in thread]