[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeplasma-addons/applets/rememberthemilk
From:       Andrew Stromme <astromme () chatonka ! com>
Date:       2009-05-04 20:39:44
Message-ID: 1241469584.402057.32436.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 963516 by astromme:

Use the much cleaner KToolInvocation::invokeBrowser() slot rather than KRun::runUrl. \
Thanks to pinotree

 M  +0 -1      CMakeLists.txt  
 M  +2 -8      rememberthemilk-plasmoid.cpp  
 M  +1 -2      rememberthemilk-plasmoid.h  


--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/CMakeLists.txt #963515:963516
@@ -21,7 +21,6 @@
                       ${KDE4_PLASMA_LIBS}
                       ${KDE4_SOLID_LIBS}
                       ${KDE4_KDEUI_LIBS}
-                      ${KDE4_KIO_LIBS}
                      )
  
 install(TARGETS plasma_applet_rtm
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/rememberthemilk-plasmoid.cpp \
#963515:963516 @@ -38,7 +38,7 @@
 #include <KConfigDialog>
 #include <KLineEdit>
 #include <KDebug> 
-#include <KRun>
+#include <KToolInvocation>
 
 // Plasma Includes
 #include <Plasma/Theme>
@@ -73,7 +73,7 @@
     m_authWidget = new QWidget();
     m_authWidgetUi->setupUi(m_authWidget);
     m_generalOptions = new QWidget();
-    connect(m_authWidgetUi->signupLabel, SIGNAL(leftClickedUrl(const QString&)), \
SLOT(signupUrlClicked(const QString&))); +    connect(m_authWidgetUi->signupLabel, \
SIGNAL(leftClickedUrl(const QString&)), KToolInvocation::self(), \
SLOT(invokeBrowser(const QString&)));  m_generalOptionsUi->setupUi(m_generalOptions);
     m_generalOptionsUi->sortType->addItem(i18n("Due Date"));
     m_generalOptionsUi->sortType->addItem(i18n("Priority"));
@@ -125,12 +125,6 @@
   Plasma::Applet::init();
 }
 
-void RememberTheMilkPlasmoid::signupUrlClicked(const QString &url)
-{
-  KRun::runUrl(KUrl(url), "text/html", m_authWidget);
-}
-
-
 void RememberTheMilkPlasmoid::configAccepted() {
   if (!m_authWidgetUi->username->text().isEmpty()) {
       // Remove/replace tabs?
--- trunk/KDE/kdeplasma-addons/applets/rememberthemilk/rememberthemilk-plasmoid.h \
#963515:963516 @@ -64,8 +64,7 @@
 
   public slots:
     void dataUpdated(const QString &name, const Plasma::DataEngine::Data &data);
-
-    void signupUrlClicked(const QString &url);
+    
     void showTaskEditor(QModelIndex index);
     void onTaskEditorHide();
     


[prev in list] [next in list] [prev in thread] [next in thread]