[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/work/sok-progress-in-icons/runtime/kuiserver
From:       Shaun Reich <shaun.reich () kdemail ! net>
Date:       2009-05-03 23:18:35
Message-ID: 1241392715.165142.6139.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 963129 by sreich:

* Commented out the emission of a signal, I'm not sure what the crap that actually \
does, since I couldn't find anything that connected to it.

* Turned a JobView into a pointer, I think that is the right way of doing it... not \
sure if it would be leaking or not, since I thought that it would hand it off to the \
array...

 M  +4 -1      jobview.h  
 M  +1 -1      progresslistdelegate.cpp  
 M  +1 -1      progresslistmodel.cpp  


--- branches/work/sok-progress-in-icons/runtime/kuiserver/jobview.h #963128:963129
@@ -56,11 +56,14 @@
     void clearDescriptionField(uint number);
 
     QDBusObjectPath objectPath() const;
+    
 
 Q_SIGNALS:
     void suspendRequested();
     void resumeRequested();
-    void cancelRequested();
+
+//I don't get it, this is never connected to... void cancelRequested();
+
     void changed(JobView*);
 
 private:
--- branches/work/sok-progress-in-icons/runtime/kuiserver/progresslistdelegate.cpp \
#963128:963129 @@ -366,7 +366,7 @@
     const QModelIndex index = focusedIndex();
     JobView *jobView = index.model()->data(index, \
ProgressListModel::JobViewRole).value<JobView*>();  if (jobView) {
-        emit jobView->cancelRequested();
+        //FIXME emit jobView->cancelRequested();
     }
 }
 
--- branches/work/sok-progress-in-icons/runtime/kuiserver/progresslistmodel.cpp \
#963128:963129 @@ -201,7 +201,7 @@
 
 JobView* ProgressListModel::newJob(const QString &appName, const QString &appIcon, \
int capabilities)  {
-    JobView newJob = new JobView();
+    JobView* newJob = new JobView();
     newJob.setSuspended(false);
 
     //TODO: FIXME FIXME


[prev in list] [next in list] [prev in thread] [next in thread]