[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevplatform/language/duchain
From:       David Nolden <david.nolden.kde () art-master ! de>
Date:       2009-04-30 21:14:52
Message-ID: 1241126092.331188.7956.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 961886 by zwabel:

Switch from noReferenceCounting to doReferenceCounting, since it seems that \
during global destruction the value is set to false, and this way it \
hopefully won't cause problems


 M  +3 -3      referencecounting.cpp  
 M  +2 -2      referencecounting.h  


--- trunk/KDE/kdevplatform/language/duchain/referencecounting.cpp \
#961885:961886 @@ -27,7 +27,7 @@
 #include "repositories/itemrepository.h"
 
 namespace KDevelop {
-  bool noReferenceCounting = true;
+  bool doReferenceCounting = false;
 }
 
 struct RefCountDecider {
@@ -86,7 +86,7 @@
     refcounting().ranges.erase(it);
   
   if(refcounting().ranges.isEmpty())
-    noReferenceCounting = true;
+    doReferenceCounting = false;
   
   refcounting().mutex.unlock();
 }
@@ -95,7 +95,7 @@
 {
   refcounting().mutex.lock();
   
-  noReferenceCounting = false;
+  doReferenceCounting = true;
   
   QMap< void*, QPair<uint, uint> >::iterator it = \
refcounting().ranges.upperBound(start);  if(it != \
                refcounting().ranges.begin()) {
--- trunk/KDE/kdevplatform/language/duchain/referencecounting.h \
#961885:961886 @@ -29,11 +29,11 @@
 
 namespace KDevelop {
   KDEVPLATFORMLANGUAGE_EXPORT bool \
                shouldDoDUChainReferenceCountingInternal(void* item);
-  KDEVPLATFORMLANGUAGE_EXPORT extern bool noReferenceCounting;
+  KDEVPLATFORMLANGUAGE_EXPORT extern bool doReferenceCounting;
   ///This is used by indexed items to decide whether they should do \
reference-counting  inline bool shouldDoDUChainReferenceCounting(void* \
item)   {
-    if(noReferenceCounting) //Fast path, no place has been marked for \
reference counting, 99% of cases +    if(!doReferenceCounting) //Fast path, \
no place has been marked for reference counting, 99% of cases  return \
false;  return shouldDoDUChainReferenceCountingInternal(item);
   }


[prev in list] [next in list] [prev in thread] [next in thread]