[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/xml
From:       Viacheslav Tokarev <tsjoker () gmail ! com>
Date:       2009-04-29 16:15:45
Message-ID: 1241021745.644767.8095.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 961195 by vtokarev:

We already have preparsed class attribute for every DOM element (for
faster css selectors) no reason to do it here all over again
less code and better performance - nice :)

 M  +2 -8      ClassNodeList.cpp  


--- trunk/KDE/kdelibs/khtml/xml/ClassNodeList.cpp #961194:961195
@@ -53,16 +53,10 @@
     if (!m_classNames.size())
         return false;
 
-    ClassNames classes;
-    ElementImpl* el = static_cast<ElementImpl*>(testNode);
-    const DOMString cn = el->getAttribute(ATTR_CLASS);
-    bool const compat = el->document()->inCompatMode();
-    classes.parseClassAttribute(cn, compat);
-    for (size_t i = 0; i < m_classNames.size(); ++i) {
+    const ClassNames& classes = static_cast<ElementImpl*>(testNode)->classNames();
+    for (size_t i = 0; i < m_classNames.size(); ++i)
         if (!classes.contains(m_classNames[i]))
             return false;
-    }
-
     return true;
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]