[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/xml
From:       Maks Orlovich <maksim () kde ! org>
Date:       2009-04-18 15:55:13
Message-ID: 1240070113.404399.4297.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 955823 by orlovich:

automatically merged revision 955821:
Don't crash when attempting attribute value normalization during removeAttribute
BUG: 188061

 M  +6 -0      dom_elementimpl.cpp  


--- trunk/KDE/kdelibs/khtml/xml/dom_elementimpl.cpp #955822:955823
@@ -318,6 +318,12 @@
 void AttributeImpl::rewriteValue( const DOMString& newValue )
 {
     if (m_localName.id()) {
+	// We may have m_data.value == null if we were given a normalized value
+	// off a removeAttribute (which would call parseNullAttribute()). 
+	// Ignore such requests.
+	if (!m_data.value)
+	    return;
+	
 	DOMStringImpl* value = newValue.implementation();
 	if (m_data.value == value)
 	    return;

[prev in list] [next in list] [prev in thread] [next in thread]