[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevplatform/plugins/mercurial
From:       Fabian Wiesel <fabian.wiesel () googlemail ! com>
Date:       2009-04-05 9:02:37
Message-ID: 1238922157.441061.17819.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 949398 by wiesel:

Fixes Krazy issues with the mercurial-plugin:
- Implicit conversion constructor
- Missing const-reference in foreach loop

 M  +1 -1      mercurialplugin.cpp  
 M  +1 -1      mercurialplugin.h  


--- trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp #949397:949398
@@ -747,7 +747,7 @@
                 QStringList unparsedParentList = parents.split(QChar(' '), QString::SkipEmptyParts);
                 // id:Short-node
                 static const unsigned int shortNodeSuffixLen = 13;
-                foreach(QString p, unparsedParentList) {
+                foreach(const QString & p, unparsedParentList) {
                     QString ids = p.left(p.size() - shortNodeSuffixLen);
                     id = ids.toUInt(&success);
 
--- trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.h #949397:949398
@@ -56,7 +56,7 @@
     friend class MercurialExecutor;
 
 public:
-    MercurialPlugin(QObject *parent, const QVariantList & args = QVariantList());
+    explicit MercurialPlugin(QObject *parent, const QVariantList & args = QVariantList());
     ~MercurialPlugin();
 
     bool isValidDirectory(const KUrl &dirPath);
[prev in list] [next in list] [prev in thread] [next in thread]