[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepim/akonadi/resources/mbox/libmbox (silent)
From:       Bertjan Broeksema <b.broeksema () home ! nl>
Date:       2009-04-04 19:08:16
Message-ID: 1238872096.584883.10653.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 949264 by bbroeksema:

SVN_SILENT: "== QString()" => "isEmpty()"


 M  +2 -2      mbox.cpp  
 M  +3 -3      tests/mboxtest.cpp  


--- trunk/KDE/kdepim/akonadi/resources/mbox/libmbox/mbox.cpp #949263:949264
@@ -111,14 +111,14 @@
 
   switch (d->mLockType) {
     case procmail_lockfile:
-      if (KStandardDirs::findExe("lockfile") == QString()) {
+      if (KStandardDirs::findExe("lockfile").isEmpty()) {
         errorMsg = i18n("Could not find the lockfile executable");
         return false;
       }
       break;
     case mutt_dotlock: // fall through
     case mutt_dotlock_privileged:
-      if (KStandardDirs::findExe("mutt_dotlock") == QString()) {
+      if (KStandardDirs::findExe("mutt_dotlock").isEmpty()) {
         errorMsg = i18n("Could not find the mutt_dotlock executable");
         return false;
       }
--- trunk/KDE/kdepim/akonadi/resources/mbox/libmbox/tests/mboxtest.cpp #949263:949264
@@ -62,7 +62,7 @@
   MBox mbox1(fileName(), true); // ReadOnly
   QVERIFY(mbox1.isValid());     // FCNTL is the default lock method.
 
-  if (KStandardDirs::findExe("lockfile") != QString()) {
+  if (!KStandardDirs::findExe("lockfile").isEmpty()) {
     mbox1.setLockType(MBox::procmail_lockfile);
     QVERIFY(mbox1.isValid());
   } else {
@@ -70,7 +70,7 @@
     QVERIFY(!mbox1.isValid());
   }
 
-  if (KStandardDirs::findExe("mutt_dotlock") != QString()) {
+  if (!KStandardDirs::findExe("mutt_dotlock").isEmpty()) {
     mbox1.setLockType(MBox::mutt_dotlock);
     QVERIFY(mbox1.isValid());
     mbox1.setLockType(MBox::mutt_dotlock_privileged);
@@ -101,7 +101,7 @@
   // found.
   MBox mbox(fileName(), true);
   mbox.setLockType(MBox::procmail_lockfile);
-  if (KStandardDirs::findExe("lockfile") != QString()) {
+  if (!KStandardDirs::findExe("lockfile").isEmpty()) {
     QVERIFY(!QFile(fileName() + ".lock").exists());
     mbox.open();
     QVERIFY(QFile(fileName() + ".lock").exists());
[prev in list] [next in list] [prev in thread] [next in thread]