[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/pim/krss/resources/libkrssresource
From:       Dmitry Ivanov <vonami () gmail ! com>
Date:       2009-04-04 13:18:58
Message-ID: 1238851138.003260.15860.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 949074 by divanov:

Make it less error-prone


 M  +2 -4      importopmljob.cpp  
 M  +0 -1      importopmljob.h  


--- trunk/playground/pim/krss/resources/libkrssresource/importopmljob.cpp #949073:949074
@@ -324,8 +324,7 @@
         return;
     }
 
-    m_jobs.reserve( m_tagLabels.count() );
-    m_tags.reserve( m_tagLabels.count() );
+    m_tags.fill( KRss::Tag(), m_tagLabels.count() );
     Q_FOREACH( const QString& label, m_tagLabels ) {
         KRss::Tag tag;
         tag.setLabel( label );
@@ -333,7 +332,6 @@
         connect( job, SIGNAL( result( KJob* ) ), this, SLOT( slotTagCreated( KJob* ) ) );
         job->setTag( tag );
         ++m_pendingJobs;
-        m_jobs.append( job );
         job->start();
     }
 }
@@ -350,7 +348,7 @@
 
     const KRss::TagCreateJob * const tjob = qobject_cast<const KRss::TagCreateJob*>( job );
     assert( tjob );
-    m_tags.insert( m_jobs.indexOf( job ), tjob->tag() );
+    m_tags.insert( m_tagLabels.indexOf( tjob->tag().label() ), tjob->tag() );
 
     if ( m_pendingJobs > 0 )
         return;
--- trunk/playground/pim/krss/resources/libkrssresource/importopmljob.h #949073:949074
@@ -101,7 +101,6 @@
 private:
     const KRss::TagProvider *m_tagProvider;
     QList<QString> m_tagLabels;
-    QVector<KJob*> m_jobs;
     QVector<KRss::Tag> m_tags;
     int m_pendingJobs;
 };
[prev in list] [next in list] [prev in thread] [next in thread]