[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui/xmlgui
From:       David Faure <faure () kde ! org>
Date:       2009-03-31 21:47:27
Message-ID: 1238536047.049893.32277.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 947616 by dfaure:

minor optimization


 M  +4 -3      kxmlguibuilder.cpp  


--- trunk/KDE/kdelibs/kdeui/xmlgui/kxmlguibuilder.cpp #947615:947616
@@ -291,7 +291,8 @@
   if (index > 0 && index < parent->actions().count())
       before = parent->actions().at(index);
 
-  if ( element.tagName().toLower() == d->tagSeparator )
+  const QString tagName = element.tagName().toLower();
+  if (tagName == d->tagSeparator)
   {
     if ( QMenu *menu = qobject_cast<QMenu*>( parent ) )
     {
@@ -332,11 +333,11 @@
       return bar->insertSeparator( before );
     }
   }
-  else if ( element.tagName().toLower() == d->tagTearOffHandle )
+  else if (tagName == d->tagTearOffHandle)
   {
     static_cast<QMenu *>(parent)->setTearOffEnabled(true);
   }
-  else if ( element.tagName().toLower() == d->tagMenuTitle )
+  else if (tagName == d->tagMenuTitle)
   {
     if ( KMenu* m = qobject_cast<KMenu*>( parent ) )
     {
[prev in list] [next in list] [prev in thread] [next in thread]