From kde-commits  Tue Mar 31 20:03:55 2009
From: Frank Osterfeld <frank.osterfeld () gmx ! de>
Date: Tue, 31 Mar 2009 20:03:55 +0000
To: kde-commits
Subject: Re: playground/pim/krss/resources/libkrssresource
Message-Id: <200903312203.55817.frank.osterfeld () gmx ! de>
X-MARC-Message: https://marc.info/?l=kde-commits&m=123852989921923

How much is left to be done until we can kill resource/ ?

On Tuesday 31 March 2009 16:37:16 Dmitry Ivanov wrote:
> SVN commit 947458 by divanov:
>
> Copy & adapt the ItemImportReader test
>
>
>  M  +3 -1      itemimportreader.h
>  M  +4 -0      tests/CMakeLists.txt
>  AM            tests/itemimportreadertest.cpp  
> trunk/playground/pim/krss/resource/tests/itemimportreadertest.cpp#946108
> [License: GPL (v2+)] AM            tests/itemimportreadertest.h  
> trunk/playground/pim/krss/resource/tests/itemimportreadertest.h#946108
> [License: GPL (v2+)]
>
>
> --- trunk/playground/pim/krss/resources/libkrssresource/itemimportreader.h
> #947457:947458 @@ -18,6 +18,8 @@
>  #ifndef KRSSRESOURCE_ITEMIMPORTREADER_H
>  #define KRSSRESOURCE_ITEMIMPORTREADER_H
>
> +#include "krssresource_export.h"
> +
>  #include <QString>
>  #include <QXmlStreamReader>
>
> @@ -30,7 +32,7 @@
>  namespace KRssResource
>  {
>
> -class ItemImportReader {
> +class KRSSRESOURCE_TESTS_EXPORT ItemImportReader {
>  public:
>      explicit ItemImportReader( QIODevice* dev );
>      ~ItemImportReader();
> ---
> trunk/playground/pim/krss/resources/libkrssresource/tests/CMakeLists.txt
> #947457:947458 @@ -5,6 +5,9 @@
>      ${CMAKE_CURRENT_SOURCE_DIR}/../
>  )
>
> +# path to test data
> +add_definitions(-DTESTDATAPATH=\\"${CMAKE_CURRENT_SOURCE_DIR}\\")
> +
>  macro(add_akonadi_isolated_test _testName _configName)
>    set(_targetName ${_testName})
>    set(_configFile ${_configName})
> @@ -40,5 +43,6 @@
>  endmacro(add_simple_test)
>
>  add_simple_test(rssitemsynctest rssitemsynctest.cpp)
> +add_simple_test(itemimportreadertest itemimportreadertest.cpp)
>  add_akonadi_isolated_test(importopmljobtest config1.xml
> importopmljobtest.cpp) add_akonadi_isolated_test(importitemsjobtest
> config2.xml importitemsjobtest.cpp) **
> trunk/playground/pim/krss/resources/libkrssresource/tests/itemimportreadert
>est.cpp #property svn:mergeinfo +
> **
> trunk/playground/pim/krss/resources/libkrssresource/tests/itemimportreadert
>est.h #property svn:mergeinfo +