[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: KDE/kdelibs/khtml/xml
From: Allan Sandfeld Jensen <kde () carewolf ! com>
Date: 2009-03-28 23:08:42
Message-ID: 200903290008.43306.kde () carewolf ! com
[Download RAW message or body]
On Saturday 28 March 2009, Allan Sandfeld Jensen wrote:
> On Friday 27 March 2009, Viacheslav Tokarev wrote:
> > SVN commit 945551 by vtokarev:
> >
> > Use remaind bit in NodeImpl for storing :hover dependency of element on
> > itself which appeared to be very popular
>
> I don't think this change is correct. It won't work when the hover
> dependency is non-trivial. The reason this simple system works in WebKit is
> because if they see a single descent or sibling rule they set a global flag
> and then restyle all children on all changes. We are much more accurate
> than that.
>
Sorry, I read it again, and it only use the flag for trivial dependencies, so
it is safe. Maybe it should just be expanded to other trivial dependency types
to save time and space in the dependency map.
`Allan
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'Monospace'; font-size:10pt; \
font-weight:400; font-style:normal;">On Saturday 28 March 2009, Allan Sandfeld Jensen \
wrote:<br> > On Friday 27 March 2009, Viacheslav Tokarev wrote:<br>
> > SVN commit 945551 by vtokarev:<br>
> ><br>
> > Use remaind bit in NodeImpl for storing :hover dependency of element on<br>
> > itself which appeared to be very popular<br>
><br>
> I don't think this change is correct. It won't work when the hover<br>
> dependency is non-trivial. The reason this simple system works in WebKit is<br>
> because if they see a single descent or sibling rule they set a global flag<br>
> and then restyle all children on all changes. We are much more accurate<br>
> than that.<br>
><br>
Sorry, I read it again, and it only use the flag for trivial dependencies, so it is \
safe. Maybe it should just be expanded to other trivial dependency types to save time \
and space in the dependency map.<br> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>`Allan</p></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic