[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/dialogs
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2009-03-28 15:17:26
Message-ID: 20090328151726.GA8867 () ugly ! local
[Download RAW message or body]

moin,

gave it another round of thought ...

On Mon, Mar 02, 2009 at 07:02:57PM -0500, Michael Pyne wrote:
> On Friday 27 February 2009, Oswald Buddenhagen wrote:
> > On Fri, Feb 27, 2009 at 04:07:36AM +0000, Michael Pyne wrote:
> > > Disable auto default buttons in KDialog (user code can set it back
> > > if they want).
> >
> > that's a bad idea. most people actually *do* expect the currently
> > focused button to react to enter.
> 
> My change was inspired by the case of dialogs that have default
> buttons and no "focused" button.  For those dialogs setting a default
> button has no effect since they didn't also set the focus to the
> default button.  This is possibly dangerous for dialogs where the
> default is "Cancel" but the focus ends up on OK/Continue/etc. due to
> how the dialog is constructed.
> 
so the problem is actually that the concept of default buttons simply
makes no sense in a dialog with only buttons. autodefault doesn't make
the problem worse as such - it just breaks the rather counter-intuitive
work-around.
so the proper solution would be (assuming we want magic behavior at all
instead of fixing the applications): if pushbuttons are the only
focusable widgets in the dialog
- automatically focus the default button
- possibly even remove that button's default property afterwards
[prev in list] [next in list] [prev in thread] [next in thread]