[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/k3b/src/projects
From:       Ralf Habacker <ralf.habacker () freenet ! de>
Date:       2009-03-27 21:34:28
Message-ID: 49CD4664.5000401 () freenet ! de
[Download RAW message or body]

Sebastian Trüg schrieb:
> On Friday 27 March 2009 21:04:24 Ralf Habacker wrote:
>   
>> SVN commit 945617 by habacker:
>>
>> win32 msvc compile fix
>>
>>  M  +3 -2      k3baudioeditorwidget.cpp
>>
>>
>> --- trunk/extragear/multimedia/k3b/src/projects/k3baudioeditorwidget.cpp
>> #945616:945617 @@ -648,13 +648,14 @@
>>      m_draggedMarker = 0;
>>
>>      bool end;
>> -    if( Range* r = findRangeEdge( e->pos(), &end ) ) {
>> +	Range* r;
>> +    if( r = findRangeEdge( e->pos(), &end ) ) {
>>          m_draggedRange = r;
>>          m_draggingRangeEnd = end;
>>          setSelectedRange( r );
>>      }
>>      else {
>> -        Range* r = findRange( e->pos() );
>> +        r = findRange( e->pos() );
>>          d->movedRange = r;
>>          d->lastMovePosition = posToMsf( e->pos().x() );
>>          setSelectedRange( r );
>>     
>
> will we need a lot of these? Because I find it very ugly to have an undefined 
> pointer, even if only for one line.
>   
No, this is the only case I stumbled about.

Ralf


[prev in list] [next in list] [prev in thread] [next in thread]