[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/systemsettings
From:       David Faure <faure () kde ! org>
Date:       2009-03-25 1:14:44
Message-ID: 1237943684.528308.9631.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 944091 by dfaure:

The analysis and patch from 169710 are correct: better pass a KService::Ptr than an \
entryPath QString. Faster and more accurate in case of duplicate desktop files for \
                the same entryPath. Doesn't fix kcmshell4 though.
CCBUG: 169710


 M  +2 -2      mainwindow.cpp  


--- trunk/KDE/kdebase/workspace/systemsettings/mainwindow.cpp #944090:944091
@@ -112,7 +112,7 @@
         QString category = \
                entry->property("X-KDE-System-Settings-Category").toString();
         //kDebug() << "Examining category " << parentCategory << "/" << category;
         if ( parentCategory == parent->name ) {
-            KCModuleInfo module( entry->entryPath() );
+            KCModuleInfo module(entry);
 
             MenuItem * menuItem = new MenuItem(true, parent);
             menuItem->name = category;
@@ -130,7 +130,7 @@
         if(!parent->name.isEmpty() && category == parent->name ) {
             kDebug() << space << "found module '" << entry->name() << "' " << \
entry->entryPath();  // Add the module info to the menu
-            KCModuleInfo module(entry->entryPath());
+            KCModuleInfo module(entry);
             kDebug() << space << "filename is " << module.fileName();
             //append(module);
             MenuItem * infoItem = new MenuItem(false, parent);


[prev in list] [next in list] [prev in thread] [next in thread]