[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/resources
From:       Thomas Zander <zander () kde ! org>
Date:       2009-03-23 21:22:33
Message-ID: 200903232222.34117.zander () kde ! org
[Download RAW message or body]


Heya,

The QtCore directory is useful to have in installed headers so users of this 
library are not forced to add all subdirs of Qt includes to their include 
path. Its a feature you just removed, was that intentional?
I think there is also a krazy test for it that probably explains it better 
than I did :)

On Monday 23. March 2009 22.02.47 Boudewijn Rempt wrote:
> SVN commit 943449 by rempt:
>
> make it possible to retrieve a resource by filename or resource name
>
>  M  +72 -18    KoResourceServer.h  
>
>
> --- trunk/koffice/libs/resources/KoResourceServer.h #943448:943449
> @@ -23,12 +23,13 @@
>  #ifndef KORESOURCESERVER_H
>  #define KORESOURCESERVER_H
>  
> -#include <QtCore/QMutex>
> -#include <QtCore/QMutexLocker>
> -#include <QtCore/QString>
> -#include <QtCore/QStringList>
> -#include <QtCore/QList>
> -#include <QtCore/QFileInfo>
> +#include <QMutex>
> +#include <QMutexLocker>
> +#include <QString>
> +#include <QStringList>
> +#include <QList>
> +#include <QHash>
> +#include <QFileInfo>
[]

>+        if ( resource->filename().isEmpty() ) {
>+            resource->setFilename( resource->name() );
>+        }
>+        else if ( resource->name().isEmpty() ) {
>+            resource->setName( resource->filename() );
>+        }

Please watch the coding style; its   "if (foo)" so you added too many spaces 
here;
http://techbase.kde.org/Policies/Kdelibs_Coding_Style

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]