[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/HACKING/templates
From:       Dan Meltzer <parallelgrapefruit () gmail ! com>
Date:       2009-03-21 15:11:27
Message-ID: 46059ce10903210811l681cb625o262bbebdc4db2ebe () mail ! gmail ! com
[Download RAW message or body]

On Sat, Mar 21, 2009 at 11:05 AM, Mark Kretschmann <kretschmann@kde.org> wrote:
> On Sat, Mar 21, 2009 at 3:25 PM, Dan Meltzer
> <parallelgrapefruit@gmail.com> wrote:
>> On Sat, Mar 21, 2009 at 7:42 AM, Mark Kretschmann <kretschmann@kde.org> wrote:
>>> SVN commit 942192 by markey:
>>>
>>> Remove @author from my Template header, as this is a) redundant, b) not
>>> useful if there are several authors.
>>>
>>>  M  +1 -2      Template.h
>>>
>>>
>>> --- trunk/extragear/multimedia/amarok/HACKING/templates/Template.h #942191:942192
>>> @@ -21,9 +21,8 @@
>>>  #include <QObject>
>>>
>>>  /**
>>> - * A class for
>>> + * A class for blah
>>>  *
>>> - * @author Foo Bar <foo@bar.com>
>>>  **/
>>>  class AMAROK_EXPORT Template : public QObject
>>
>> Not sure if the export should be in the template.... many classes are
>> probably going to be used for libamarok only, (in which case the
>> export isn't needed).  If one gets linking errors it's always easy
>> enough to add on an as needed basis.
>
> Yeah, shrug, I added it cause I thought removing it is easier than
> typing it, if needed...
>
> It's prolly debatable, but then not that important really. Kinda bikeshedding :)
Well, it keeps the symbol size down, which I think helps library load
times.  Exporting everything kinda defeats the purpose of hidden
visibility.  This also is going to do really wrong things for any
class thats not a part of libamarok.
>
> --
> Mark Kretschmann
> Amarok Developer
> www.kde.org - amarok.kde.org
>

[prev in list] [next in list] [prev in thread] [next in thread]