[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/pim/krss
From:       Dmitry Ivanov <vonami () gmail ! com>
Date:       2009-03-20 8:21:36
Message-ID: 1237537296.928459.6108.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 941648 by divanov:

 - add flag 'Deleted'
 - protect ItemImportReader with unit tests as I'm going
   to rework flag handling throughout libkrss


 M  +2 -1      libkrss/item.h  
 M  +1 -1      resource/itemimportreader.cpp  
 M  +4 -0      resource/tests/CMakeLists.txt  
 A             resource/tests/itemimportreadertest.cpp   [License: GPL (v2+)]
 A             resource/tests/itemimportreadertest.h   [License: GPL (v2+)]
 A             resource/tests/testdata/planetkde-imported.xml  


--- trunk/playground/pim/krss/libkrss/item.h #941647:941648
@@ -45,7 +45,8 @@
 enum StatusFlags {
     New         = 0x01,
     Read        = 0x02,
-    Important   = 0x04
+    Important   = 0x04,
+    Deleted     = 0x08
 };
 
 class KRSS_EXPORT Item
--- trunk/playground/pim/krss/resource/itemimportreader.cpp #941647:941648
@@ -241,7 +241,7 @@
                     status |= KRss::Important;
             } else if ( el.deleted.isNextIn( reader ) ) {
                 if ( reader.readElementText() == "true" )
-                    ; //TODO
+                    status |= KRss::Deleted;
             }
 
         }
--- trunk/playground/pim/krss/resource/tests/CMakeLists.txt #941647:941648
@@ -15,3 +15,7 @@
 # importopmljobtest
 kde4_add_unit_test(importopmljobtest importopmljobtest.cpp ../importopmljob.cpp)
 target_link_libraries(importopmljobtest ${QT_QTTEST_LIBRARY} ${KDE4_AKONADI_LIBS} \
${KDE4_KIO_LIBS} ${QT_QTGUI_LIBRARY} krss) +
+# itemimportreadertest
+kde4_add_unit_test(itemimportreadertest itemimportreadertest.cpp \
../itemimportreader.cpp) +target_link_libraries(itemimportreadertest \
${QT_QTTEST_LIBRARY} ${KDE4_AKONADI_LIBS} ${KDE4_KIO_LIBS} ${QT_QTGUI_LIBRARY} krss)


[prev in list] [next in list] [prev in thread] [next in thread]