[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kexi/core
From:       Jaroslaw Staniek <js () iidea ! pl>
Date:       2009-03-19 23:09:03
Message-ID: 1237504143.291886.30228.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 941556 by staniek:

Core
= better sanity check: fix crash when more than one object
  with Part ID == -1 is encountered in kexi__objects table



 M  +7 -3      kexiproject.cpp  


--- trunk/koffice/kexi/core/kexiproject.cpp #941555:941556
@@ -601,10 +601,14 @@
     for (cursor->moveFirst(); !cursor->eof(); cursor->moveNext()) {
         bool ok;
         int partId = cursor->value(3).toInt(&ok);
-        if (!ok)
+        if (!ok || partId <= 0)
             continue;
-        if (recentPartId != partId) {
-            // create next part items dict
+        if (recentPartId == partId) {
+            if (partClass.isEmpty()) // still the same unknown part id
+                continue;
+        }
+        else {
+            // new part id: create next part items dict if it's id for a known class
             recentPartId = partId;
             partClass = classForId( partId );
             if (partClass.isEmpty())
[prev in list] [next in list] [prev in thread] [next in thread]