[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeedu/marble/src/lib
From:       Henry de Valence <hdevalence () gmail ! com>
Date:       2009-03-15 16:48:52
Message-ID: 1237135732.025800.5542.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 939758 by hdevalence:

Fix Krazy issue: non-const d-pointer


 M  +3 -3      Planet.cpp  
 M  +1 -1      Planet.h  


--- trunk/KDE/kdeedu/marble/src/lib/Planet.cpp #939757:939758
@@ -55,15 +55,15 @@
 
 //Constructor
 Planet::Planet()
+    : d( new PlanetPrivate )
 {
-    d = new PlanetPrivate;
     d->setup( 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
             QObject::tr("Unknown Planet", "a planet without data"), QString("unknown") );
 }
 
 Planet::Planet( const QString& id )
+    : d( new PlanetPrivate )
 {
-    d = new PlanetPrivate;
     // constants taken from
     // http://www.astro.uu.nl/~strous/AA/en/reken/zonpositie.html
     if ( id == "mercury" ) {
@@ -153,8 +153,8 @@
 
 //Copy Constructor
 Planet::Planet( const Planet& other )
+    : d( new PlanetPrivate )
 {
-    d = new PlanetPrivate;
     d->M_0 = other.M_0();
     d->M_1 = other.M_1();
     d->C_1 = other.C_1();
--- trunk/KDE/kdeedu/marble/src/lib/Planet.h #939757:939758
@@ -92,7 +92,7 @@
     void operator=( const Planet& other );
 
 private:
-    PlanetPrivate * d;
+    PlanetPrivate * const d;
 };
 
 
[prev in list] [next in list] [prev in thread] [next in thread]