[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/khtml/css
From:       Maks Orlovich <maksim () kde ! org>
Date:       2009-03-11 17:32:33
Message-ID: 1236792753.055577.10396.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 938365 by orlovich:

Fix off-by-one that caused an infinite loop with explosive memory use.
Yey for fancy version control systems that exceed human ability to keep track of stuff!


 M  +1 -1      cssstyleselector.cpp  


--- trunk/KDE/kdelibs/khtml/css/cssstyleselector.cpp #938364:938365
@@ -1974,7 +1974,7 @@
 
     // presort properties. Should make the sort() calls in styleForElement faster.
     qSort(propertyList.begin(), propertyList.end(), CSSOrderedPropertyList::compareItems);
-    properties_size = propertyList.count() + 1;
+    properties_size = propertyList.count();
     properties = new CSSOrderedProperty *[ properties_size ];
     propertiesBuffer = new CSSOrderedProperty[properties_size];
     CSSOrderedProperty **prop = properties;
[prev in list] [next in list] [prev in thread] [next in thread]