[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdeplasma-addons/applets/nowplaying
From:       Alex Merry <kde () randomguy3 ! me ! uk>
Date:       2009-03-09 22:34:26
Message-ID: 1236638066.835998.19460.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 937561 by alexmerry:

Don't feed back when we change to a shorter track.  Caused a shorter track played after a \
longer one to skip straight to the end.



 M  +4 -3      nowplaying.cpp  


--- trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp #937560:937561
@@ -75,8 +75,6 @@
     m_positionSlider->setMinimum(0);
     m_positionSlider->setMaximum(0);
     m_positionSlider->setValue(0);
-    connect(this, SIGNAL(lengthChanged(int)),
-            m_positionSlider, SLOT(setMaximum(int)));
     connect(m_positionSlider, SIGNAL(valueChanged(int)),
             this, SLOT(setPosition(int)));
     m_positionSlider->setEnabled(false);
@@ -246,10 +244,13 @@
     int length = data["Length"].toInt();
     if (length != m_length) {
         m_length = length;
+
+        m_positionSlider->blockSignals(true);
         if (length == 0) {
             updatePositionSlider(0);
         }
-        emit lengthChanged(m_length);
+        m_positionSlider->setMaximum(length);
+        m_positionSlider->blockSignals(false);
     }
     if (length != 0) {
         int pos = data["Position"].toInt();


[prev in list] [next in list] [prev in thread] [next in thread]