[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdepimlibs/kabc
From:       Allen Winter <winter () kde ! org>
Date:       2009-03-08 1:21:35
Message-ID: 1236475295.037714.32440.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 936586 by winterz:

remove the ContactGroupTool class and replace it with a namespace
since there are only static methods there.

approved by tokoe.

we are permitted because this is new in 4.3.



 M  +29 -30    contactgrouptool.h  


--- trunk/KDE/kdepimlibs/kabc/contactgrouptool.h #936585:936586
@@ -34,44 +34,43 @@
 class ContactGroup;
 
 /**
- * @short A class for converting ContactGroup to XML format and vice versa.
+ * Static methods for converting ContactGroup to XML format and vice versa.
  *
  * @author Kevin Krammer <kevin.krammer@gmx.at>
  * @since 4.3
  */
-class KABC_EXPORT ContactGroupTool //krazy:exclude=dpointer only static functions
-{
-  public:
-    /**
-     * Converts XML data coming from a @p device into a contact @p group.
-     * If an error occurs, @c false is returned and @p errorMessage is set.
-     */
-    static bool convertFromXml( QIODevice *device, ContactGroup &group,
-                                QString *errorMessage = 0 );
+namespace ContactGroupTool {
 
-    /**
-     * Converts a contact @p group into XML data and writes them to a @p device.
-     * If an error occurs, @c false is returned and @p errorMessage is set.
-     */
-    static bool convertToXml( const ContactGroup &group, QIODevice *device,
-                              QString *errorMessage = 0 );
+  /**
+   * Converts XML data coming from a @p device into a contact @p group.
+   * If an error occurs, @c false is returned and @p errorMessage is set.
+   */
+  KABC_EXPORT bool convertFromXml( QIODevice *device, ContactGroup &group,
+                                   QString *errorMessage = 0 );
 
-    /**
-     * Converts XML data coming from a @p device into a @p list of contact groups.
-     * If an error occurs, @c false is returned and @p errorMessage is set.
-     */
-    static bool convertFromXml( QIODevice *device,
-                                QList<ContactGroup> &list,
-                                QString *errorMessage = 0 );
+  /**
+   * Converts a contact @p group into XML data and writes them to a @p device.
+   * If an error occurs, @c false is returned and @p errorMessage is set.
+   */
+  KABC_EXPORT bool convertToXml( const ContactGroup &group, QIODevice *device,
+                                 QString *errorMessage = 0 );
 
-    /**
-     * Converts a @p list of contact groups into XML data and writes them to a @p device.
-     * If an error occurs, @c false is returned and @p errorMessage is set.
-     */
-    static bool convertToXml( const QList<ContactGroup> &list,
-                              QIODevice *device, QString *errorMessage = 0 );
-};
+  /**
+   * Converts XML data coming from a @p device into a @p list of contact groups.
+   * If an error occurs, @c false is returned and @p errorMessage is set.
+   */
+  KABC_EXPORT bool convertFromXml( QIODevice *device,
+                                   QList<ContactGroup> &list,
+                                   QString *errorMessage = 0 );
 
+  /**
+   * Converts a @p list of contact groups into XML data and writes them to a @p device.
+   * If an error occurs, @c false is returned and @p errorMessage is set.
+   */
+  KABC_EXPORT bool convertToXml( const QList<ContactGroup> &list,
+                                 QIODevice *device, QString *errorMessage = 0 );
 }
 
+}
+
 #endif
[prev in list] [next in list] [prev in thread] [next in thread]