[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdegraphics/gwenview/lib
From:       Aurélien Gâteau <aurelien.gateau () free ! fr>
Date:       2009-03-06 13:09:49
Message-ID: 49B1209D.5020701 () free ! fr
[Download RAW message or body]

David Faure wrote:
> On Thursday 05 March 2009, Aurélien Gâteau wrote:
>> SVN commit 935635 by gateau:
>>
>> Some KImageIO plugins (jpeg2000, grrr) return mimetype aliases instead of the real mimetype.
>> Resolv alias for now.
> 
> Why it that a problem? I mean, what is the code doing with the result of dirMimeTypes()
> and rasterImageMimeTypes()?
> 
> I keep wondering if KMimeType::mimeType() shouldn't resolve mimetypes automatically
> (in fact I'm quite sure I should have made it that way initially), but now changing the behavior
> seems risky.
> 
> But I'm surprised you have to resolve and then return strings again, so surely the caller
> is going to have to look up the mimetypes with KMimeType again -- or otherwise aliases
> wouldn't be a problem? Or is this because of string comparisons? Missing a bit of the big picture.

Here is the situation: I query the file for its mimetype, then need to 
check whether it is an image.

For performance reason (maybe it's premature optimization?) I store all 
image mimetypes in a QStringList, so that I can do my check using 
QStringList::contains().

>> David, should we fix the .desktop files instead?
> 
> Can't hurt to do that too :-)
> 

OK, will do.

Aurélien


[prev in list] [next in list] [prev in thread] [next in thread]