[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/libs/main
From:       Thomas Zander <zander () kde ! org>
Date:       2009-02-28 22:09:16
Message-ID: 1235858956.339775.29729.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 933431 by zander:

Fixes: Crash if right click in a split view
BUG:185336
Details: In the KOffice1 days we used KParts to do what flake does now and there
    we handled right clicks on another kpart by the surrounding kpart.
    This, however, means that right clicking on a splitted view calls into a non-active
    view and that causes a crash because the factory is zero.
    So lets remove this old code and be happy.

 M  +0 -4      KoMainWindow.cpp  


--- trunk/koffice/libs/main/KoMainWindow.cpp #933430:933431
@@ -82,10 +82,6 @@
         setSelectionPolicy(KParts::PartManager::TriState);
         setAllowNestedParts(true);
         setIgnoreScrollBars(true);
-        // Allow right-click on embedded objects (without activating them)
-        // But beware: this means right-click on parent, from embedded object,
-        // doesn't make the parent active first...
-        setActivationButtonMask(Qt::LeftButton | Qt::MidButton);
     }
     virtual bool eventFilter(QObject *obj, QEvent *ev) {
         if (!obj->isWidgetType() || ::qobject_cast<KoFrame *>(obj))
[prev in list] [next in list] [prev in thread] [next in thread]