[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/flake/tools
From:       jaham () gmx ! net
Date:       2009-02-28 21:26:38
Message-ID: 200902282226.38824.jaham () gmx ! net
[Download RAW message or body]

On Saturday 28 February 2009 22:19:57 Thomas Zander wrote:
> Would it not be easier to just comment out the adding of the action to the
> collection?
> As tool actions get disabled when the tool gets deselected and re-enabled
> when the action gets activated this solution may have sideeffects.

Yes that would be better. Will do that in a moment.

>
> On Tuesday 17. February 2009 22.19.27 Jan Hambrecht wrote:
> > SVN commit 927577 by jaham:
> >
> > disable merge points button as the function is not implemented yet
> >
> > CCBUG:184644
> >
> >
> >
> >  M  +2 -1      KoPathTool.cpp
> >
> >
> > --- trunk/koffice/libs/flake/tools/KoPathTool.cpp #927576:927577
> > @@ -128,6 +128,7 @@
> >      addAction("pathpoint-join", m_actionJoinSegment);
> >      connect(m_actionJoinSegment, SIGNAL(triggered()), this,
> > SLOT(joinPoints()));
> >
> > +    // TODO: implement me
> >      m_actionMergePoints = new KAction(KIcon("pathpoint-merge"),
> > i18n("Merge points"), this); m_actionMergePoints->setEnabled(false); //
>
> not
>
> > implemented yet. addAction("pathpoint-merge", m_actionMergePoints);
> > @@ -675,7 +676,7 @@
> >      m_actionCurveSegment->setEnabled(hasSegmentsSelected);
> >      m_actionBreakSegment->setEnabled(hasPointsSelected &&
> > m_pointSelection.objectCount() == 1 && m_pointSelection.size() == 2);
> > m_actionJoinSegment->setEnabled(hasPointsSelected &&
> > m_pointSelection.objectCount() == 1 && m_pointSelection.size() == 2); -
> > //m_actionMergePoints->setEnabled(false);
> > +    m_actionMergePoints->setEnabled(false);
> >  }
> >
> >  void KoPathTool::deactivate()


[prev in list] [next in list] [prev in thread] [next in thread]