[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevplatform/language/duchain
From:       David Nolden <david.nolden.kde () art-master ! de>
Date:       2009-02-28 16:18:37
Message-ID: 1235837917.552860.30826.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 933308 by zwabel:

Do not un-alias types for template-parameters. This may lead to slight problems in \
type-conversion, because different typedefs of the same type will not be matched to \
each other, but leads to much nicer code-completion, because a std::list<std::string> \
shows std::string within the code-completion, instead of the ugly un-typedeffed \
version.


 M  +4 -2      instantiationinformation.cpp  


--- trunk/KDE/kdevplatform/language/duchain/instantiationinformation.cpp \
#933307:933308 @@ -60,9 +60,11 @@
   return ret;
 }
 
-void InstantiationInformation::addTemplateParameter(TypePtr< KDevelop::AbstractType \
> type) { +void InstantiationInformation::addTemplateParameter(KDevelop::AbstractType::Ptr \
> type) {
   ///@todo This is C++ specific: Only the un-aliased types play a role for \
                template-parameters
-  templateParametersList().append(TypeUtils::unAliasedType(type)->indexed());
+  ///@todo Do deep un-aliasing. Example: A pointer to an aliased type
+//   templateParametersList().append(TypeUtils::unAliasedType(type)->indexed());
+  templateParametersList().append(type->indexed());
 }
 
 QString InstantiationInformation::toString(bool local) const {


[prev in list] [next in list] [prev in thread] [next in thread]