[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    playground/base/kcontrol4/src
From:       Mathias Soeken <soeken () pprojekt ! de>
Date:       2009-02-28 16:14:18
Message-ID: 1235837658.942779.30331.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 933304 by msoeken:

Problem with ClassicMode::mModuleView not being initialized to 0


 M  +4 -4      app/SettingsBase.cpp  
 M  +1 -1      classic/ClassicMode.cpp  


--- trunk/playground/base/kcontrol4/src/app/SettingsBase.cpp #933303:933304
@@ -203,11 +203,11 @@
         activeView = possibleViews.values().first();
     }
 
-    if ( activeView->moduleView() ) {
-      // FIXME this crashes
-      // connect(activeView->moduleView(), SIGNAL(moduleChanged()), this, SLOT(moduleChanged()));
+    setCentralWidget(activeView->mainWidget()); // Now we set it as the main widget
+
+    if ( activeView->moduleView() ) {     
+        connect(activeView->moduleView(), SIGNAL(moduleChanged()), this, SLOT(moduleChanged()));
     }
-    setCentralWidget(activeView->mainWidget()); // Now we set it as the main widget
 }
 
 void SettingsBase::toggleDirtyState(bool state)
--- trunk/playground/base/kcontrol4/src/classic/ClassicMode.cpp #933303:933304
@@ -38,7 +38,7 @@
 K_PLUGIN_FACTORY(ClassicModeFactory, registerPlugin<ClassicMode>();)
 K_EXPORT_PLUGIN(ClassicModeFactory("classic_mode"))
 
-ClassicMode::ClassicMode( QObject * parent, const QVariantList& ) : BaseMode( parent )
+ClassicMode::ClassicMode( QObject * parent, const QVariantList& ) : BaseMode( parent ), mModuleView( 0 )
 {
     KComponentData plugin = ClassicModeFactory::componentData();
     aboutClassic = new KAboutData( "KControl4_TreeView", 0, ki18n("Control Center Tree View"),
[prev in list] [next in list] [prev in thread] [next in thread]