[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: qt-copy
From:       David Faure <faure () kde ! org>
Date:       2009-02-23 21:57:59
Message-ID: 200902232258.00470.faure () kde ! org
[Download RAW message or body]

On Monday 23 February 2009, Alexis Ménard wrote:
> Same why patching the src file directly? 

So that others don't lose time debugging the same issue. The fix is from you guys
so it's "safe enough" to be applied unconditionnally (it will be in rc2 anyway...), so
better make sure everyone benefits from it, rather than everyone with encoding
trouble spending hours debugging their kioslave.
[encoding trouble on the command line needs a kcmdlineargs patch using the bool
below so I can't commit it yet].

> It can be a big mess especially if 
> i don't want to apply the patch or write another one that doesn't need this
> one to work...

Well the patch is also in 0272-qiconvcodec-fix.diff so you can easily revert it.
You're questionning the whole "Applied: yes" support, but it's nothing new and
it didn't create problems even though we had it for a long time.

-- 
David Faure, faure@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]