[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: qt-copy
From:       Alexis_Ménard <menard () kde ! org>
Date:       2009-02-23 21:48:52
Message-ID: 81941aea0902231348k3c0bb84fj41b59d6739f898f6 () mail ! gmail ! com
[Download RAW message or body]

This thing has been reporting to Qt Software ?

It should be reported...

Btw is it the correct way to patch directly the src files? Because i think
it will start to be a big mess if evreybody start to commit directly in the
source files. Especially to delete patches, commit that need to be removed
or more for merging at each patch release. I am not sure what is the policy
here.

On Mon, Feb 23, 2009 at 10:39 PM, Fredrik H=F6glund <fredrik@kde.org> wrote=
:

> On Monday 23 February 2009, Andreas Hartmetz wrote:
> > Looks like this completely ruins painting performance with graphicssyst=
em
> > raster for me, both on my desktop with Radeon HD 2400 and radeonhd (ope=
n
> > source) driver and on my laptop with Intel i845 and the usual Intel
> driver.
> > The symptoms are e.g. choppy scrolling in KHTML and a visible delay whe=
n
> > repainting the client area of a tabwidget. Painting issues with
> transparent
> > GIFs in KHTML are also still there - just for completeness. I was hopin=
g
> to
> > see those fixed by the patch :)
>
> The patch doesn't fix any regressions, it's about not using a deprecated
> function that many drivers (including the Intel one) no longer support.
>
> Qt would still work with those drivers, but it would end up taking a
> fallback
> path that doesn't use shared memory.
>
> With this change, scrolling large windows is noticeably faster for me wit=
h
> the radeon driver.
>
> > Painting now seems to be slightly slower than with graphicssystem nativ=
e
> > overall, worse in some cases like in the text widget I'm writing this
> email.
> > I guess we need somebody to tell us what's happening here :)
> > The patch description looks sane to me, but I don't really understand X
> > performance and/or driver issues.
>
> I've attached another patch that tweaks the code a bit to avoid ending
> up in a problematic code path in the X server. It also changes the code
> to not use SHM with smaller updates, since the sync call that follows it
> can actually make it slower in that case.
>
> Does this patch fix the problems you are seeing?
>
> Regards,
> Fredrik
>
>

[Attachment #3 (text/html)]

This thing has been reporting to Qt Software ?<br><br>It should be \
reported...<br><br>Btw is it the correct way to patch directly the src files? Because \
i think it will start to be a big mess if evreybody start to commit directly in the \
source files. Especially to delete patches, commit that need to be removed or more \
for merging at each patch release. I am not sure what is the policy here.<br> \
<br><div class="gmail_quote">On Mon, Feb 23, 2009 at 10:39 PM, Fredrik Höglund <span \
dir="ltr">&lt;<a href="mailto:fredrik@kde.org">fredrik@kde.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d">On Monday \
23 February 2009, Andreas Hartmetz wrote:<br> &gt; Looks like this completely ruins \
painting performance with graphicssystem<br> &gt; raster for me, both on my desktop \
with Radeon HD 2400 and radeonhd (open<br> &gt; source) driver and on my laptop with \
Intel i845 and the usual Intel driver.<br> &gt; The symptoms are e.g. choppy \
scrolling in KHTML and a visible delay when<br> &gt; repainting the client area of a \
tabwidget. Painting issues with transparent<br> &gt; GIFs in KHTML are also still \
there - just for completeness. I was hoping to<br> &gt; see those fixed by the patch \
:)<br> <br>
</div>The patch doesn&#39;t fix any regressions, it&#39;s about not using a \
deprecated<br> function that many drivers (including the Intel one) no longer \
support.<br> <br>
Qt would still work with those drivers, but it would end up taking a fallback<br>
path that doesn&#39;t use shared memory.<br>
<br>
With this change, scrolling large windows is noticeably faster for me with<br>
the radeon driver.<br>
<div class="Ih2E3d"><br>
&gt; Painting now seems to be slightly slower than with graphicssystem native<br>
&gt; overall, worse in some cases like in the text widget I&#39;m writing this \
email.<br> &gt; I guess we need somebody to tell us what&#39;s happening here :)<br>
&gt; The patch description looks sane to me, but I don&#39;t really understand X<br>
&gt; performance and/or driver issues.<br>
<br>
</div>I&#39;ve attached another patch that tweaks the code a bit to avoid ending<br>
up in a problematic code path in the X server. It also changes the code<br>
to not use SHM with smaller updates, since the sync call that follows it<br>
can actually make it slower in that case.<br>
<br>
Does this patch fix the problems you are seeing?<br>
<br>
Regards,<br>
<font color="#888888">Fredrik<br>
<br>
</font></blockquote></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]