[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdelibs/kdeui
From:       David Faure <faure () kde ! org>
Date:       2009-02-19 14:44:01
Message-ID: 1235054641.637658.14240.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 928418 by dfaure:

Make sure the QComboBox insertItems method can be called (e.g. by uic) despite the \
protected method in KHistoryComboBox having the same name.


 M  +6 -0      tests/kcombobox_unittest.cpp  
 M  +2 -0      widgets/khistorycombobox.h  


--- trunk/KDE/kdelibs/kdeui/tests/kcombobox_unittest.cpp #928417:928418
@@ -81,6 +81,12 @@
         QCOMPARE(comboActivatedSpy[0][0].toString(), QString("Hello world"));
     }
 
+    void testHistoryComboInsertItems()
+    {
+        KHistoryComboBox combo;
+        // uic generates code like this, let's make sure it compiles
+        combo.insertItems(0, QStringList() << "foo");
+    }
 };
 
 QTEST_KDEMAIN(KComboBox_UnitTest, GUI)
--- trunk/KDE/kdelibs/kdeui/widgets/khistorycombobox.h #928417:928418
@@ -179,6 +179,8 @@
      */
     void reset();
 
+    using QComboBox::insertItems;
+
 public Q_SLOTS:
     /**
      * Adds an item to the end of the history list and to the completion list.


[prev in list] [next in list] [prev in thread] [next in thread]