[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/workspace/plasma/containments/desktop
From:       Chani <chanika () gmail ! com>
Date:       2009-02-15 0:55:33
Message-ID: 200902141655.43654.chanika () gmail ! com
[Download RAW message or body]


On February 12, 2009 11:10:25 Ambroz Bizjak wrote:
> SVN commit 925216 by abizjak:
>
> Add safeguards to avoid an infinite loop, compiler/Qt bug suspected.

since you suspect a bug, are you working on finding that bug?

> +            if ((align & Qt::AlignTop)) {
> +                newY = a.bottom();
> +                if (!(newY > y)) return possiblePositions;

nitpick: always use {} with if statements, please.
also, ! and > is less clear than just <=

-- 
This message brought to you by eevil bananas and the number 3.
www.chani3.com

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]