[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kchart/shape
From:       Johannes Simon <johannes.simon () gmail ! com>
Date:       2009-01-31 19:35:17
Message-ID: 1233430517.001610.25734.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 919344 by jsimon:

Fix fourth of The Eight Release Critical Bugs: "Remove axis title when axis is removed"

 M  +3 -0      Axis.cpp  
 M  +3 -0      PlotArea.cpp  


--- trunk/koffice/kchart/shape/Axis.cpp #919343:919344
@@ -641,6 +641,9 @@
 {
     Q_ASSERT( d->plotArea );
     d->plotArea->parent()->KoShapeContainer::removeChild( d->title );
+    Q_ASSERT( d->title );
+    if ( d->title )
+        delete d->title;
     delete d;
 }
 
--- trunk/koffice/kchart/shape/PlotArea.cpp #919343:919344
@@ -350,6 +350,9 @@
             _axis->deregisterKdXAxis( axis->kdAxis() );
     }
     
+    // This also removes the axis' title, which is a shape as well
+    delete axis;
+    
     requestRepaint();
     
     return true;
[prev in list] [next in list] [prev in thread] [next in thread]