[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/base/PolicyKit-kde/manager
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2009-01-22 13:33:13
Message-ID: 200901221433.13558.l.lunak () suse ! cz
[Download RAW message or body]

On Tuesday 20 of January 2009, Daniel Nicoletti wrote:
> SVN commit 914105 by dantti:
>
> Set the AuthDialog modal to darken the parent window
>
>  M  +2 -8      AuthDialog.cpp
>  M  +2 -1      policykitkde.cpp
>
>
> --- trunk/extragear/base/PolicyKit-kde/manager/AuthDialog.cpp
>  AuthDialog::AuthDialog(PolKitPolicyFileEntry *entry, uint pid)
>
>          : KDialog(0, Qt::Dialog | Qt::WindowStaysOnTopHint |
>          : Qt::CustomizeWindowHint)

 Is there any reason for this manual fiddling with flags? The setMainWindow() 
call will keep the dialog above the parent window and I don't see what's so 
special about this window that it should be kept on top of all windows. 
Please remove this.

>          KWindowSystem::setMainWindow(dialog, wid);
> -    } else
> +    } else {
>          updateUserTimestamp(); // make it get focus unconditionally :-/
> +    }
>
>      parent_wid = wid;
-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz
[prev in list] [next in list] [prev in thread] [next in thread]