[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps/plasma/applets/folderview
From:       Carlo <brandon.ml () gmail ! com>
Date:       2009-01-09 12:40:45
Message-ID: 3262b6180901090440m18b7b502s8ba84a8c8b21ae33 () mail ! gmail ! com
[Download RAW message or body]

On Fri, Jan 9, 2009 at 12:48 PM, Marijn Kruisselbrink
<m.kruisselbrink@student.tue.nl> wrote:
> On Friday 09 January 2009 12:41:59 David Faure wrote:
>> On Friday 09 January 2009, Carlo Segato wrote:
>> > SVN commit 908146 by segato:
>> >
>> > little windows fix
>> >
>> >  M  +2 -0      iconview.cpp
>> >
>> >
>> > --- trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp
>> > #908145:908146 @@ -19,7 +19,9 @@
>> >   */
>> >
>> >  #include "iconview.h"
>> > +#ifndef Q_WS_WIN
>> >  #include <fixx11h.h>
>> > +#endif
>>
>> Might be a good idea to move the ifndef into the fixx11h.h file itself,
>> so that this problem can't happen again.
> Also, wouldn't the proper fix be an #ifdef Q_WS_X11 instead of only fixing
> this for windows?
>
>
>
fixx11h.h isn't installed on windows/osx so I can't move the ifdef
there, and yeah it would be better as ifdef Q_WS_X11
[prev in list] [next in list] [prev in thread] [next in thread]