[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/context/applets/currenttrack
From:       "Dan Meltzer" <parallelgrapefruit () gmail ! com>
Date:       2009-01-08 19:05:21
Message-ID: 46059ce10901081105m3ba3030aod84b198fd41c3dc3 () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jan 8, 2009 at 1:50 PM, Mark Kretschmann <kretschmann@kde.org> wrote:
> SVN commit 907803 by markey:
>
> Don't show the rating widget for tracks which are not in the collection.

inCollection() returns true if the track is in _any_ collection... so
this fix is not all that accurate, the rating will be shown for
ampache (and other) tracks still.

Either we should check for the statistics capability (which Seb added,
if I recall) or, the ideal solution (and the pain in the ass one)
would be to allow for rating tracks not in any collection (storing
them by uniqueid with their rating in the collection database....  The
first solution is probably a whole lot easier to do than the second.
>
> BUG: 180023
>
>  M  +6 -0      CurrentTrack.cpp
>
>
> --- trunk/extragear/multimedia/amarok/src/context/applets/currenttrack/CurrentTrack.cpp #907802:907803
> @@ -416,6 +416,12 @@
>
>     Meta::TrackPtr track = The::engineController()->currentTrack();
>
> +    // Only show the ratings widget if the current track is in the collection
> +    if( track && track->inCollection() )
> +        m_ratingWidget->show();
> +    else
> +        m_ratingWidget->hide();
> +
>     //don't paint this until we have something better looking that also works with non square covers
>     /*if( track && track->album() && track->album()->hasImage() )
>         m_theme->paint( p, QRect( margin - 5, margin, albumWidth + 12, albumWidth ), "cd-box" );*/
>
[prev in list] [next in list] [prev in thread] [next in thread]